Skip to content

Wasm/runtime: put back caml_string_of_array #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wasm/runtime: put back caml_string_of_array #2081

wants to merge 1 commit into from

Conversation

vouillon
Copy link
Member

Brr is using this function. This is an alias for caml_string_of_uint8_array.

@vouillon
Wasm/runtime: put back caml_string_of_array
e45edc8 
Brr is using this function. This is an alias for caml_string_of_uint8_array.
@dbuenzli
Copy link
Contributor

We can also fix brr.

@dbuenzli
Copy link
Contributor

I did that here. Does that update the lower bound (I have {>= "5.5.0"} at the moment) ?

@vouillon
Copy link
Member Author

I was going to suggest a fix, indeed. caml_string_of_uint8_array was introduced in Js_of_ocaml 6.0.1.

@dbuenzli
Copy link
Contributor

Thanks pinning --dev-repo should do. I should also do a release soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vouillon @dbuenzli